summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDaniel Baumann <daniel.baumann@open-infrastructure.net>2022-06-14 05:08:32 +0000
committerDaniel Baumann <daniel.baumann@open-infrastructure.net>2022-06-14 11:59:26 +0000
commit9608d919189ea73dc001ea97062d89b49991d811 (patch)
tree5e4ce56720a2d12f77f11746deb53a60c6836bfd
parentUsing read -r to not mangle backslashes in git-tools. (diff)
downloadservice-tools-9608d919189ea73dc001ea97062d89b49991d811.tar.xz
service-tools-9608d919189ea73dc001ea97062d89b49991d811.zip
Adding quotes arround some variables in git-tools to prevent globbing and word splitting.
Signed-off-by: Daniel Baumann <daniel.baumann@open-infrastructure.net>
-rwxr-xr-xgit/bin/git-checkout-branches2
-rwxr-xr-xgit/bin/git-whoami2
-rwxr-xr-xgit/share/hooks/post-update.d/irker-notification2
3 files changed, 3 insertions, 3 deletions
diff --git a/git/bin/git-checkout-branches b/git/bin/git-checkout-branches
index c0c586c..220386f 100755
--- a/git/bin/git-checkout-branches
+++ b/git/bin/git-checkout-branches
@@ -29,7 +29,7 @@ do
BRANCH="$(echo "${REMOTE_BRANCH}" | cut -d/ -f 2-)"
case "${BRANCH}" in
- HEAD|${CURRENT_BRANCH})
+ HEAD|"${CURRENT_BRANCH}")
continue
;;
esac
diff --git a/git/bin/git-whoami b/git/bin/git-whoami
index 9cab9bc..bf1645d 100755
--- a/git/bin/git-whoami
+++ b/git/bin/git-whoami
@@ -14,7 +14,7 @@ get_email() {
}
get_name() {
- git config user.name || getent passwd $(id -un) | cut -d : -f 5 | cut -d , -f 1
+ git config user.name || getent passwd "$(id -un)" | cut -d : -f 5 | cut -d , -f 1
}
: ${GIT_AUTHOR_NAME=$(get_name)}
diff --git a/git/share/hooks/post-update.d/irker-notification b/git/share/hooks/post-update.d/irker-notification
index aae89e6..7c712db 100755
--- a/git/share/hooks/post-update.d/irker-notification
+++ b/git/share/hooks/post-update.d/irker-notification
@@ -30,5 +30,5 @@ echo "sending IRC notification"
while read -r OLD NEW REFNAME
do
- irkerhook --refname=${REFNAME} $(git rev-list --reverse ${OLD}..${NEW})
+ irkerhook --refname="${REFNAME}" "$(git rev-list --reverse "${OLD}".."${NEW}")"
done